Repository navigation
fix: MATCH ... CREATE ... RETURN creates once per row (GQLITE-T-0488) - #200
Merged
Merged
Conversation
When the RETURN read no variable that only the CREATE bound, the MATCH+CREATE+RETURN handler ran MATCH+CREATE, then the MATCH again for the RETURN: a CREATE that bound no matched variable ran once (or for a MATCH with no rows), and the RETURN saw the new nodes. That fallback now runs in the row pipeline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MATCH (a) CREATE (a)-[:T]->(:New) RETURN acreated one node, not one per row, and the RETURN rows included the new node.MATCH (a:Missing) CREATE (:New) RETURN count(*)created a node. Also in v0.12.0.Test plan
Semantic coverage matrix
Checklist